Docs: Fix 404 link in filters document #15836
Conversation
Fix 404 link
nitishkaila
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki and
youknowriad
as code owners
| @@ -4,4 +4,4 @@ | |||
|
|
|||
| There are two types of hooks: [Actions](https://developer.wordpress.org/plugins/hooks/actions/) and [Filters](https://developer.wordpress.org/plugins/hooks/filters/). In addition to PHP actions and filters, WordPress also provides a mechanism for registering and executing hooks in JavaScript. This functionality is also available on npm as the [@wordpress/hooks](https://www.npmjs.com/package/@wordpress/hooks) package, for general purpose use. | |||
|
|
|||
| You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](/packages/tree/master/packages/hooks). | |||
| You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](https://developer.wordpress.org/block-editor/packages/packages-hooks/). | |||
There was a problem hiding this comment.
This link needs to work also on GitHub:
| You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](https://developer.wordpress.org/block-editor/packages/packages-hooks/). | |
| You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [/packages/hooks/README.md). |
There was a problem hiding this comment.
@nitishkaila thanks for your contribution, can you update the link as suggested above before I merge this PR?
There was a problem hiding this comment.
It's work on github too. I have already added full link in github. so it's definitely work.
Still if you have any query please let me know.
There was a problem hiding this comment.
Yes, it does. However please check these document:
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/document.md#using-links
There can be a different version of docs at https://developer.wordpress.org/ because it covers the latest stable version of WordPress and GitHub can be a few weeks ahead.
There was a problem hiding this comment.
Thank you @gziolo to clarify. I have updated the link.
There was a problem hiding this comment.
Thanks, I can imagine it's confusing but we operate with a very specific setup where we sync changes to WordPress core through npm packages so it enforces a set of rules to ensure everything works properly :)
Update with correct URL
youknowriad
added
the
First-time Contributor
Fix 404 link which is reported bug in following link.
Closes #15834
Description
I have added @wordpress/hooks for javascript hook and filter.